Thread (16 messages) 16 messages, 3 authors, 2008-09-23

Re: [ath9k-devel] ath9k: massive unexplained latency in 2.6.27 (rc5, rc6, probably others)

From: Luis R. Rodriguez <hidden>
Date: 2008-09-22 16:01:59
Also in: lkml

Possibly related (same subject, not in this thread)

On Mon, Sep 22, 2008 at 8:11 AM, Steven Noonan [off-list ref] wrote:
On Mon, Sep 22, 2008 at 1:06 AM, Luis R. Rodriguez
[off-list ref] wrote:
quoted
Please test the following patch.
diff --git a/drivers/net/wireless/ath9k/core.c b/drivers/net/wireless/ath9k/core.c
index c262ef2..9a51739 100644
--- a/drivers/net/wireless/ath9k/core.c
+++ b/drivers/net/wireless/ath9k/core.c
@@ -681,10 +681,12 @@ int ath_open(struct ath_softc *sc, struct ath9k_channel *initial_chan)
        * Enable MIB interrupts when there are hardware phy counters.
        * Note we only do this (at the moment) for station mode.
        */
+#if 0
       if (ath9k_hw_phycounters(ah) &&
           ((sc->sc_ah->ah_opmode == ATH9K_M_STA) ||
            (sc->sc_ah->ah_opmode == ATH9K_M_IBSS)))
               sc->sc_imask |= ATH9K_INT_MIB;
+#endif
       /*
        * Some hardware processes the TIM IE and fires an
        * interrupt when the TIM bit is set.  For hardware
It didn't apply to -rc7, but I managed to apply it manually
(apparently you made this for wireless-testing?) and added the #if 0.
After 7 hours uptime with the driver, no apparent interrupt storm.

I'll do more thorough testing later, but I have a 3 hour drive today,
and some packing to do, so it'll need to wait a bit.
Yeah I did it for wireless-testing. Good to hear this so far has
solved the issue. I'll port it to 27 and post it once I get your
blessings that this fixed it by a Tested-by.

  Luis
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help