Thread (9 messages) 9 messages, 4 authors, 2008-07-27

Re: [PATCH 2/2] RFKILL: set the status of the leds on activation.

From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Date: 2008-07-27 13:57:41

On Sun, 27 Jul 2008, Ivo van Doorn wrote:
On Sunday 27 July 2008, Dmitry Baryshkov wrote:
quoted
On Tue, Jul 22, 2008 at 07:11:35PM +0200, Ivo van Doorn wrote:
quoted
On Tuesday 22 July 2008, Dmitry Baryshkov wrote:
quoted
Provide default activate function to set the state of the led
when the led becomes bound to the trigger

Signed-off-by: Dmitry Baryshkov <redacted>
Cc: Ivo van Doorn <redacted>
Cc: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Acked-by: Ivo van Doorn <redacted>
Sorry to bother you, but can I expect these patches to be merged
before 2.6.27, or should I wait for 2.6.28 window?
Well they are not really bugfixes, but I'll let John decide to which tree
they should be merged.
FWIW, I consider them to be both the kind of small thing that should go in
for 2.6.27.  It considerably enhances the LED usability of rfkill.

And I think patch 2/2 qualifies as a bug fix.  I believe it makes sense even
without 1/2?

BTW, Dmitry, since you seem to use rfkill LED, could I convince you to try
your hand at moving all the LED functionality from the current "hooks inside
the code paths" we use in rfkill.c to a "rfkill notify handler-based"
approach?  The could should get cleaner and maybe even lose some LOC with
that refactoring...  Maybe it can even go into a separate module.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help