Thread (17 messages) 17 messages, 7 authors, 2008-06-27

Re: [PATCH/RFC] remove irqs_disabled warning from local_bh_enable

From: Ingo Molnar <hidden>
Date: 2008-06-20 15:57:40
Also in: lkml

* Michael Buesch [off-list ref] wrote:
On Friday 20 June 2008 17:27:48 Ingo Molnar wrote:
quoted
 [<c012b361>] local_bh_enable_ip+0xd1/0xe0
 [<c08d9f9f>] _spin_unlock_bh+0x2f/0x40
 [<c0471b92>] vortex_timer+0xe2/0x3e0
quoted
real bug or false positive?
Well, a timer runs with IRQs disabled, no? So this would be a bug.
indeed - agreed :) [no time for me to fix it, but can test any rfc patch.]

so score +1 for Johannes's patch. I think if it works out fine and there 
are no false positives in further testing i'll put it up for pull into 
v2.6.26 as well, as it is catching real bugs.

	Ingo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help