On Fri, Feb 22, 2008 at 04:16:49PM +0100, Johannes Berg wrote:

quoted

quoted

Hence, I think we can actually get away without more locking if we
protect the flags better. Should we use a spinlock or the atomic
set_bit()/clear_bit()/etc. operations?

Using the atomic operations seems appropriate to me.

Right, but I figured if we could get rid of the AMPDU spinlocks and just
use a single one in total (for flags as well) then that'd be of benefit
too; even with the dynamic allocation strategy (see other mail) we'd not
need to allocate two more spinlocks for ampdu.

Yes, I thought that was behind your question.  I'll let Ron comment
on the AMPDU spinlock usage.

John
-- 
John W. Linville
linville@tuxdriver.com