Re: [RFC] mac80211: add rate to ieee80211_tx_status

On Feb 4, 2008 1:14 PM, Johannes Berg [off-list ref] wrote:

Tomas Winkler wrote:

quoted

No I won't we add rate flags which are part of spec anyway  and then
plcp rate it self will be in bitrate.

quoted

        IEEE80211_RATE_HT_GF  =  1<<5,  /* green field */
        IEEE80211_RATE_HT_SGI =  1<<5,  /* short guarding interval */
        IEEE80211_RATE_HT_FAT =  1<<6, /* 40Mhz Channel */
        IEEE80211_RATE_HT_SISO        =  1<<7,
        IEEE80211_RATE_HT_MIMO        =  1<<8,
        IEEE80211_RATE_ANT_A   =  1<<8,    /* Number of antenna - no
radio goes over 3 so 4 will be enough */
        IEEE80211_RATE_ANT_B   =  1<<8,
        IEEE80211_RATE_ANT_C   =  1<<8,
        IEEE80211_RATE_ANT_D   =  1<<8,

Ah, I see. Since these flags aren't really rate specific, so shouldn't
they rather be part of the TX control, TX status and RX status directly
rather than inside the rate? The flags within the bitrate are meant to
indicate hardware capabilities and/or spec flags (like ERP) not control
flags like these are.

No, they are rate specific the are not modulation specific, each of
them can change from packet to packet.
Thanks
Tomas

johannes