Thread (3 messages) flat view 3 messages, 2 authors, 2008-01-17
STALE6786d

[PATCH] mac80211: fix RCU locking in __ieee80211_rx_handle_packet

From: Johannes Berg <johannes@sipsolutions.net>
Date: 2008-01-17 15:09:58

Commit c7a51bda ("mac80211: restructure __ieee80211_rx") extracted
__ieee80211_rx_handle_packet out of __ieee80211_rx and hence changed
the locking rules for __ieee80211_rx_handle_packet(), it is now
invoked under RCU lock. There is, however, one instance left where
it contains an rcu_read_unlock() in an error path, which is a bug.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
sparse actually detected this.... oh well

 net/mac80211/rx.c |    1 -
 1 file changed, 1 deletion(-)
--- everything.orig/net/mac80211/rx.c	2008-01-16 21:15:17.532295846 +0100
+++ everything/net/mac80211/rx.c	2008-01-16 21:15:44.002272517 +0100
@@ -1730,7 +1730,6 @@ void __ieee80211_rx_handle_packet(struct
 		ieee80211_invoke_rx_handlers(local, local->rx_handlers, &rx,
 					     rx.sta);
 		sta_info_put(sta);
-		rcu_read_unlock();
 		return;
 	}
 

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help