Thread (19 messages) 19 messages, 6 authors, 2008-01-10

Re: [PATCH wireless/arlan] Replace logical- by bit-and

From: Roel Kluin <hidden>
Date: 2008-01-10 22:19:58
Also in: lkml

Randy Dunlap wrote:
On Thu, 10 Jan 2008 20:15:53 +0100 Roel Kluin wrote:
quoted
diff --git a/drivers/net/wireless/arlan.h b/drivers/net/wireless/arlan.h
index 3ed1df7..7b7498f 100644
--- a/drivers/net/wireless/arlan.h
+++ b/drivers/net/wireless/arlan.h
@@ -485,7 +485,7 @@ struct arlan_private {
 #define clearClearInterrupt(dev){\
    writeControlRegister(dev,readControlRegister(dev) & ~ARLAN_CLEAR_INTERRUPT);}
 #define setPowerOff(dev){\
-   writeControlRegister(dev,readControlRegister(dev) | (ARLAN_POWER && ARLAN_ACCESS));\
+   writeControlRegister(dev, readControlRegister(dev) | (ARLAN_POWER & ARLAN_ACCESS));\
eh?  How does that help?
Right, sorry, please ignore my patch.
Maybe it should be (ARLAN_POWER | ARLAN_ACCESS), but some
arlan developer or someone with specs should help here...
I have CC'd the previous maintainers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help