Thread (5 messages) 5 messages, 2 authors, 2007-09-28

Re: hostapd: passing sta info struct to drivers?

From: Johannes Berg <johannes@sipsolutions.net>
Date: 2007-09-28 10:57:57

On Thu, 2007-09-27 at 18:16 -0700, Jouni Malinen wrote:
quoted
During porting the STA management to nl80211 it turned out that it would
be much nicer in the kernel if we would always set all the flags on a
STA that the kernel needs to get from hostapd.
That I might be able to support at least partially by merging together
some operations, but still, I would expect there to be valid scenarios
where it would be useful to be able to just toggle a single flag.
Are there really? I can only see three flags in the kernel being set by
hostapd, those being "authorized", "wme capable" and "shortslot
capable". Some additional flags for the userspace MLME maybe, I need to
look into that later.
Hence, I don't see any place where we'd ever need to set a single flag,
we need to keep track of all those flags anyway.

It is certainly possible to have selective flags updating but I don't
quite see the point.
This is not going to happen. struct sta_info (the one in hostapd) is
internal for the core implementation and the driver wrappers should
never touch it directly, i.e., pointer to this is not passed on purpose.
If changes to the operation between the driver wrapper and kernel is
desired, it will need to be done in a different way.
Ok. I'm still thinking about the best way to do VLAN/STA finding but I
may just do that by the AP interface VLANs are tied to. Then the only
thing I really need changed is the above flags change.

johannes

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help