Thread (27 messages) 27 messages, 1 author, 2007-09-30
STALE6829d

[PATCH 21/26] at76_usb: Remove incorrect firmware version check

From: Pavel Roskin <hidden>
Date: 2007-09-30 18:40:55
Subsystem: networking drivers (wireless), the rest · Maintainers: Johannes Berg, Linus Torvalds

The major version of the firmware reported by the device can mismatch
the version of the originally loaded firmware, as it is the case for
Belkin F5D6050.

Remove this check and assume the firmware to be working as long that the
external firmware download didn't fail and the firmware version could be
read at all.

Reported by Corey Pappas [off-list ref]

Signed-off-by: Pavel Roskin <redacted>
---

 drivers/net/wireless/at76_usb.c |   13 -------------
 1 files changed, 0 insertions(+), 13 deletions(-)

diff --git a/drivers/net/wireless/at76_usb.c b/drivers/net/wireless/at76_usb.c
index 6dc8e23..ce74e03 100644
--- a/drivers/net/wireless/at76_usb.c
+++ b/drivers/net/wireless/at76_usb.c
@@ -5454,19 +5454,6 @@ static int at76_probe(struct usb_interface *interface,
 			       ": error %d getting firmware version\n", ret);
 			goto error;
 		}
-
-		/* Major and minor version must match */
-		if (fwv.major != fwe->fw_version.major
-		    || fwv.minor != fwe->fw_version.minor) {
-			printk(KERN_ERR DRIVER_NAME
-			       ": wrong firmware version, loaded %d.%d.%d-%d, "
-			       "read back %d.%d.%d-%d\n",
-			       fwe->fw_version.major, fwe->fw_version.minor,
-			       fwe->fw_version.patch, fwe->fw_version.build,
-			       fwv.major, fwv.minor, fwv.patch, fwv.build);
-			ret = -EBUSY;
-			goto error;
-		}
 	}
 
 	priv = at76_alloc_new_device(udev);
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help