On Sat, 2007-09-29 at 15:08 +0200, Ian Schram wrote:

I couldn't follow all the rest of this thread but i think the patch below
is what you were initially after.

Not in this thread really, I was just curious here because I was
thinking of disentangling the scan and sta state machines.

I'll also send this patch to ipw3945-devel mailinglist, so it can take the
same route as my other patches.

If it works you only need to fix the whitespace issue:

+       memcpy(priv->mac_addr,conf->mac_addr, ETH_ALEN);
                              ^ missing space

and sign it off and that might address one of the points I pointed out.
However, when the interface is removed again you should also clear the
MAC address in the hardware or set the hardware to monitor mode so it no
longer acknowledges packets when in pure monitor mode.

Also, a full filter flags implementation would be good.

johannes