Thread (20 messages) 20 messages, 6 authors, 2007-09-05

Re: [RFC 2/2] mac80211: revamp interface and filter configuration

From: Johannes Berg <johannes@sipsolutions.net>
Date: 2007-09-05 11:22:02

On Wed, 2007-09-05 at 07:16 +0200, Ulrich Kunitz wrote:
I see three options to achieve this:

1) Use ieee80211_stop_queues() in ->configure_filter() and
   ieee80211_wake_queues() at the end of the workqueue function.

2) Throw away all packets until the workqueue function
   terminates.

3) Implement our own tx queue.

I prefer to do option (1) because it wouldn't require adding
additional fields to our private structure beside the work_struct
for the workqueue function, it is simple to implement and it would
not throw away any packets. Are there any side effects that I have
overlooked?
I think Michael says it's currently buggy if called outside of ->tx().

johannes

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help