Thread (1 message) 1 message, 1 author, 2007-09-01

Re: [PATCH 1/5] Net: ath5k, split hw into hw, phy and initvals

From: "Nick Kossifidis" <mickflemm@gmail.com>
Date: 2007-09-01 03:12:28
Also in: netdev

Possibly related (same subject, not in this thread)

2007/8/30, John W. Linville [off-list ref]:
On Thu, Aug 30, 2007 at 04:50:01AM +0300, Nick Kossifidis wrote:
quoted
2007/8/28, Christoph Hellwig [off-list ref]:
quoted
quoted
ath5k_hw_phy.o should probably be ath5k_phy.o by conventions used by
most drivers and ath5k_hw_inivals.o mights aswell be something like
ath5k_init.o
quoted
If you check out the code you'll see i'm using the same convention
inside them, ath5k_hw* files contain hw related functions
(ath5k_hw_<name>) while driver code has ath5k_<name>. Also ath5k_init
is misleading, file acually includes initial register settings for
I have to agree w/ Christoph -- the extra "_hw" in the names is just
a bit unwieldy.

John

P.S.  "ath5k_initvals.c" seems acceptable to me.
ACK, i'll remove _hw ;-)

-- 
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help