Thread (16 messages) 16 messages, 4 authors, 2007-07-05

Re: [RFC/PATCH] debug workqueue deadlocks with lockdep

From: Ingo Molnar <hidden>
Date: 2007-07-05 08:44:00
Also in: lkml

* Oleg Nesterov [off-list ref] wrote:
quoted
quoted
Isn't it better to call lock_release() with nested == 1 ?
Not sure, Ingo?
Ingo, could you also explain the meaning of "nested" parameter? Looks 
like it is just unneeded, lock_release_nested() does a quick check and 
use lock_release_non_nested() when hlock is not on top of stack.
hm, i forgot about that. We basically turned off all bad-nesting 
warnings in lockdep due to false positives.

the workqueue dependencies should all nest perfectly so please just use 
nested==1, even though it's a dummy right now. We might want to turn 
unlock-nest checking back on in the future. Or we'll remove that 
parameter altogether.

	Ingo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help