On 7/18/07, Tomas Winkler [off-list ref] wrote:

On 7/18/07, Johannes Berg [off-list ref] wrote:

quoted

On Tue, 2007-07-17 at 20:01 -0400, John W. Linville wrote:

quoted

quoted

Here you allocate a new frame which can be sent back to the device when
one of the aggregated frames was a multicast frame and we're an AP
device.

HT aggregtion is extension of QoS. Multicast and broadcast frames are
not QoS frames and therefore such frames  want be incorporated into an
A-MSDU.

Oops
s/want/won't/

You also correctly add extra_tx_headroom, but it seems that this

quoted

quoted

quoted

is missing some skb_reserve(extra_tx_headroom), no? Could you make a
patch adding it? I'm not sure I fully understand the code there.

Was there ever any reply to this?

I didn't get one but never double-checked the code either, the relevant
patches I had touching this have fallen off the list anyway :)

johannes