Re: [PATCH #2] Merge the Sonics Silicon Backplane subsystem

On Saturday 14 July 2007 19:26:05 Christoph Hellwig wrote:

On Sat, Jul 14, 2007 at 07:18:20PM +0200, Michael Buesch wrote:

quoted

--- /dev/null
+++ b/drivers/ssb/Makefile

@@ -0,0 +1,11 @@
+ssb-builtin-drivers-y					+= driver_chipcommon.o
+ssb-builtin-drivers-$(CONFIG_SSB_DRIVER_MIPS)		+= driver_mipscore.o
+ssb-builtin-drivers-$(CONFIG_SSB_DRIVER_PCICORE)	+= driver_pcicore.o
+
+ssb-hostsupport-$(CONFIG_SSB_PCIHOST)			+= pci.o pcihost_wrapper.o
+ssb-hostsupport-$(CONFIG_SSB_PCMCIAHOST)		+= pcmcia.o
+
+obj-$(CONFIG_SSB) += ssb.o
+
+ssb-objs	:= main.o scan.o \
+		   $(ssb-hostsupport-y) $(ssb-builtin-drivers-y)

Whoa, this makefile is more than ugly :)

Please try something like:

# core
ssb-y					+= main.o scan.o

# host support
ssb-$(CONFIG_SSB_PCIHOST)		+= pci.o pcihost_wrapper.o
ssb-$(CONFIG_SSB_PCMCIAHOST)		+= pcmcia.o

# drivers
ssb-y					+= driver_chipcommon.o
ssb-$(CONFIG_SSB_DRIVER_MIPS)		+= driver_mipscore.o
ssb-$(CONFIG_SSB_DRIVER_PCICORE)	+= driver_pcicore.o

obj-$(CONFIG_SSB)			+= ssb.o

instead

quoted

+	default y

please don't add defauly y statements for random drivers.

Thanks for your comments. I fixed that and will submit it
with the next round.

-- 
Greetings Michael.