On Tue, 2007-05-08 at 16:55 -0400, Jeff Garzik wrote:

David Miller wrote:

quoted

From: "Pekka Enberg" <redacted>

quoted

On 5/7/07, Jeff Garzik [off-list ref] wrote:

quoted

Open source is about release early, release often.  Not "hide code in a
dark corner until Christoph thinks it is perfect."  We have high
standards for upstream merged code, but that standard is not perfection.

Please. This has nothing to do with Christoph. (1) the driver seems to
break every Linux coding style convention known to man and (2) adds a
new ABI with bunch of ioctls() that apparently haven't been reviewed
properly. That's just not acceptable for mainline kernel!

quoted

I completely agree, these things should be corrected and if the the
author is being totally unresponsive to Christoph's review that's even
worse.

Um, the maintainer replied yesterday morning[1] that libertas-2.6.git 
has already been updated for these requests, will be updated some more, 
and overall was responsive to the entire list of Christoph requests.

I'm mainly concerned with removing the unnecessary ioctls before 2.6.22 
release, since that affects userspace.  The vast majority of other stuff 
is cosmetic, which is being worked on, but lower priority in my book.

I'll audit the list of ioctls and remove ones that may be objectionable,
and we'll go back through them after 2.6.22 and add back in ones that
are actually required.  Keep the API/ABI small and expand if necessary.
What's the timeframe required here?  Linville said a few days at the
most.

Dan