Thread (52 messages) 52 messages, 10 authors, 2007-05-23

Re: [PATCH] Add iwlwifi wireless drivers [part 2/2]

From: Jeff Garzik <hidden>
Date: 2007-05-18 22:50:42

James Ketrenos wrote:
Are you OK with us marking the driver as not working on big endian for 
now and getting this one fixed over time?
No.

Getting this right is a key merge requirement for all drivers.

Getting this right has also, in the past, been a proven way to find 
hidden bugs in your driver that wanted fixing anyway.

I tried reading through the thread.  From what I gathered, it sounds 
like if I want to read a value from a memory location where the adapter 
could be writing to it I would just call rmb() before I access the 
memory?  And when writing to a value, call wmb() immediately after I 
write to it?  And expunge 'volatile' from my vocabulary.
MMIO - no.  Accessors handle that for you in most cases.  For rare cases 
you might need mmiowb() or whatnot, but that is unlikely.

DMA, generally that's what people do, but it's not perfect.

	Jeff

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help