Thread (3 messages) 3 messages, 3 authors, 2007-02-22

Re: [PATCH] d80211: Fix ieee80211_ptr check

From: Johannes Berg <johannes@sipsolutions.net>
Date: 2007-02-22 14:09:54

On Wed, 2007-02-21 at 19:01 +0100, Jiri Benc wrote:
On Tue, 20 Feb 2007 18:13:54 -0500, Michael Wu wrote:
quoted
dev->ieee80211_ptr can no longer be directly compared to check if a virtual
interface belongs to a master device.
Hm, apparently the regexp I tried when resolving conflicts with John's
tree wasn't good enough to catch this :-(
No, that's an error I made.
Let's hope there are no more such things left.
I doubt it. I should have remembered this special case but forgot about
it. The thing is that in earlier wiphy versions I had ieee80211_ptr
point to the wiphy directly so I *intentionally* kept the comparison
like that when reviewing all uses of ieee80211_ptr. When I realised that
we need per-netdev wireless state I put that behind ieee80211_ptr and
then forgot to update this spot.

johannes

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help