Re: [PATCH 1/1] watchdog: dw_wdt: Remove duplicated header file inclusion

On 2021/3/28 3:50, Guenter Roeck wrote:

On 3/26/21 6:20 PM, Zhen Lei wrote:

quoted

The header file <linux/kernel.h> is already included above and can be
removed here.

Signed-off-by: Zhen Lei <redacted>

Already submitted:

https://patchwork.kernel.org/project/linux-watchdog/patch/20210325112916.865510-1-wanjiabing@vivo.com/

In general, when removing duplicate or unnecessary header files,
please retain or improve alphabetic order. This patch makes it worse.

Okay, thanks for the heads-up. I'll pay attention next time.

Guenter

quoted

---
 drivers/watchdog/dw_wdt.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/watchdog/dw_wdt.c b/drivers/watchdog/dw_wdt.c
index 32d0e1781e63c4e..b1642e2d9175584 100644
--- a/drivers/watchdog/dw_wdt.c
+++ b/drivers/watchdog/dw_wdt.c

@@ -19,7 +19,6 @@
 #include <linux/delay.h>
 #include <linux/err.h>
 #include <linux/io.h>
-#include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/moduleparam.h>
 #include <linux/interrupt.h>

.