Re: [PATCH] usb: host: ohci-exynos: Propagate clock errors from resume
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2026-09-06 06:36:40
Also in:
linux-arm-kernel, linux-samsung-soc, lkml
On 06/09/2026 05:40, Pengpeng Hou wrote:
exynos_ohci_resume() ignores clk_prepare_enable() and proceeds to PHY
No, clk_prepare_enable() is not ignored. It is called. What is ignored is the return status, because it does not matter. It cannot possibly fail, it is simple MMIO access within internals of the SoC. Anyway, please rephrase the commit msg.
and OHCI restoration.
Return a clock failure before enabling the PHY. The existing PHY failure
path continues to undo a successfully enabled clock.
The issue was found by our static-analysis tool and manually reviewed.
Fixes: e864abed546f ("USB: ohci-exynos: add clock gating to suspend/resume")IMO, I have doubts whether this is a fix, because actual error cannot happen in practice. Best regards, Krzysztof