Re: [PATCH usb-next v1] USB: gadget: Fix UAF in gadgetfs_fill_super()

On Thu, Sep 03, 2026 at 10:12:27PM -0700, Rafael Alejandro Díaz Cruz wrote:

Which changes?

I had to go back and look at the old email messages to figure out what 
you are talking about here.  Don't reply to emails without including 
enough context to let your reader (who may have to deal with hundreds of 
emails every day) know what's going on.

In this case, I was referring to the changes between your most recent 
patch submission (v1) and the submission you're planning to make (which 
will presumably be v2).

 Currently I'm on the new v1 and all I would do
is remove the top paragraph you said was unnecessary. Or do
you mean add the "Reviewed-by" tag that you added? (Thanks btw!)

I meant everything that will change between v1 and v2.  Tags and all.

I'm not sure either about adding it below the "---" line.
I haven't done that before....

Now's your chance.  :-)

I saw an example from some other patches and I guess I would
do the following:

 20 Reported-by: syzbot+4a5c87a01894ca37f25c@syzkaller.appspotmail.com
 21 Link: https://syzkaller.appspot.com/bug?extid=4a5c87a01894ca37f25c
 22 Signed-off-by: Rafael Alejandro Diaz Cruz [off-list ref]
 23 ---                                                      // ADD
THE PART BETWEEN THE "---" ?
 24 v2
 25 - Reviewed-by: Alan Stern [off-list ref]
 26 ---
 27  drivers/usb/gadget/legacy/inode.c | 1 +
 28  1 file changed, 1 insertion(+)
 29
 30 diff --git a/drivers/usb

Is this correct?

No.

All you have to do is copy the format of the other patch submissions in 
the email archives.  It should look something like this (note that 
there is only one "---" line!):

----------------------------------------------------------------
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Reported-by: syzbot+4a5c87a01894ca37f25c@syzkaller.appspotmail.com
Link: https://syzkaller.appspot.com/bug?extid=4a5c87a01894ca37f25c
Signed-off-by: Rafael Alejandro Diaz Cruz <redacted>
Reviewed-by: Alan Stern <stern@rowland.harvard.edu>
---

Changes from v1:

	Removed unnecessary reference to syzkaller in the description.

	Added Reviewed-by: tag.

 drivers/usb/gadget/legacy/inode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/legacy/inode.c b/drivers/usb/gadget/legacy/inode.c
----------------------------------------------------------------

Alan Stern