[PATCH v2 00/40] Use defined 16-bits ASC/ASCQ combinations
From: Damien Le Moal <dlemoal@kernel.org>
Date: 2026-09-03 03:42:15
Also in:
linux-ide, linux-s390, linux-scsi
Martin, James, This patch series defines as macros all ASC/ASCQ combinations present in https://www.t10.org/lists/asc-num.txt and converts the SCSI core code and SCSI low level drivers to use these macros instead of hard-coded ASC/ASCQs. To do this, struct scsi_sense_hdr and struct scsi_failure are modified to replace the asc and ascq 8-bits fields with a 16-bits sense_code field. This cleans up the code in many places and makes it easier, and self documented, to test sense codes in the case of errors. Overall, there should be no functional chnages here. Changes from v1: - Addressed Sashiko comments signaling missing "ASC_" prefix when using the named macros for ASC codes. - Fixed up patch 7 to correct trace event print of asc/ascq. Also extended the use of scsi_set_sense() in place of scsi_build_sense(). - Modified patch 37 to extend the use of scsi_set_sense_buffer() in place of scsi_build_sense_buffer(). - Added patch 34 and 38 to extend the use of scsi_set_sense() in place of scsi_build_sense(). - Added patch 40 to remove scsi_build_sense() and scsi_build_sense_buffer(). Damien Le Moal (40): scsi: define all additional sense codes and their qualifiers scsi: constants: use defined sense codes scsi: constants: rename internal struct field names scsi: rename sense field of struct scsi_failure scsi: prepare for using 16-bits defined sense codes scsi: use struct scsi_sense_hdr to log sense keys and codes scsi: core: use 16-bits defined sense codes scsi: sd: use 16-bits defined sense codes scsi: sr: use 16-bits defined sense codes scsi: ses: use 16-bits defined sense codes scsi: ch: use 16-bits defined sense codes scsi: st: use 16-bits defined sense codes scsi: device_handlers: hp_sw: use 16-bits defined sense codes scsi: device_handlers: rdac: use 16-bits defined sense codes scsi: device_handlers: emc: use 16-bits defined sense codes scsi: device_handlers: alua: use 16-bits defined sense codes scsi: mpt3sas: use 16-bits defined sense codes scsi: mpi3mr: use 16-bits defined sense codes scsi: 3w-xxxx: use 16-bits defined sense codes scsi: leapraid: use 16-bits defined sense codes scsi: megaraid: use 16-bits defined sense codes scsi: myrX: use 16-bits defined sense codes scsi: smartpqi: use 16-bits defined sense codes scsi: qla2xxx: use 16-bits defined sense codes scsi: ps3rom: use 16-bits defined sense codes scsi: lpfc: use 16-bits defined sense codes scsi: stex: use 16-bits defined sense codes scsi: mvumi: use 16-bits defined sense codes scsi: libiscsi: use 16-bits defined sense codes scsi: ibmvscsi_tgt: use 16-bits defined sense codes scsi: scsi_debug: use 16-bits defined sense codes scsi: hpsa: use 16-bits defined sense codes scsi: storvsc: use 16-bits defined sense codes target: use 16-bits defined sense codes usb: storage: use 16-bits defined sense codes cdrom: use 16-bits defined sense codes ata: libata: use 16-bits defined sense codes s390: scsi: use 16-bits defined sense codes scsi: cleanup scsi_proto.h scsi: remove scsi_build_sense() and scsi_build_sense_buffer() drivers/ata/libata-eh.c | 13 +- drivers/ata/libata-sata.c | 20 +- drivers/ata/libata-scsi.c | 346 ++- drivers/ata/libata.h | 5 +- drivers/cdrom/cdrom.c | 10 +- drivers/s390/scsi/zfcp_scsi.c | 3 +- drivers/scsi/3w-xxxx.c | 3 +- drivers/scsi/ch.c | 55 +- drivers/scsi/constants.c | 61 +- drivers/scsi/device_handler/scsi_dh_alua.c | 55 +- drivers/scsi/device_handler/scsi_dh_emc.c | 28 +- drivers/scsi/device_handler/scsi_dh_hp_sw.c | 29 +- drivers/scsi/device_handler/scsi_dh_rdac.c | 55 +- drivers/scsi/hpsa.c | 69 +- drivers/scsi/hpsa_cmd.h | 23 - drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 5 +- drivers/scsi/leapraid/leapraid_func.h | 7 - drivers/scsi/leapraid/leapraid_os.c | 15 +- drivers/scsi/libiscsi.c | 3 +- drivers/scsi/lpfc/lpfc_scsi.c | 18 +- drivers/scsi/megaraid.c | 8 +- drivers/scsi/megaraid/mega_common.h | 2 - drivers/scsi/megaraid/megaraid_mbox.c | 12 +- drivers/scsi/mpi3mr/mpi3mr_fw.c | 3 +- drivers/scsi/mpi3mr/mpi3mr_os.c | 50 +- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 69 +- drivers/scsi/mvumi.c | 2 +- drivers/scsi/myrb.c | 67 +- drivers/scsi/myrs.c | 23 +- drivers/scsi/ps3rom.c | 5 +- drivers/scsi/qla2xxx/qla_isr.c | 9 +- drivers/scsi/scsi.c | 3 +- drivers/scsi/scsi_common.c | 24 +- drivers/scsi/scsi_debug.c | 332 +-- drivers/scsi/scsi_error.c | 94 +- drivers/scsi/scsi_ioctl.c | 3 +- drivers/scsi/scsi_lib.c | 130 +- drivers/scsi/scsi_lib_test.c | 96 +- drivers/scsi/scsi_logging.c | 22 +- drivers/scsi/scsi_scan.c | 22 +- drivers/scsi/scsi_transport_spi.c | 12 +- drivers/scsi/sd.c | 126 +- drivers/scsi/sd_zbc.c | 2 +- drivers/scsi/sense_codes.h | 2496 ++++++++++++------ drivers/scsi/ses.c | 23 +- drivers/scsi/smartpqi/smartpqi_init.c | 31 +- drivers/scsi/sr.c | 3 +- drivers/scsi/sr_ioctl.c | 29 +- drivers/scsi/st.c | 35 +- drivers/scsi/stex.c | 3 +- drivers/scsi/storvsc_drv.c | 15 +- drivers/target/target_core_spc.c | 11 +- drivers/target/target_core_transport.c | 11 +- drivers/target/target_core_ua.c | 28 +- drivers/target/target_core_ua.h | 7 +- drivers/usb/gadget/function/f_mass_storage.c | 34 +- drivers/usb/gadget/function/storage_common.h | 71 +- drivers/usb/storage/debug.c | 12 +- drivers/usb/storage/debug.h | 4 +- drivers/usb/storage/transport.c | 7 +- include/scsi/scsi_cmnd.h | 3 +- include/scsi/scsi_common.h | 16 +- include/scsi/scsi_dbg.h | 6 +- include/scsi/scsi_device.h | 26 +- include/scsi/scsi_proto.h | 71 +- include/scsi/scsi_sense.h | 943 +++++++ include/trace/events/scsi.h | 4 +- 67 files changed, 3821 insertions(+), 2007 deletions(-) create mode 100644 include/scsi/scsi_sense.h -- 2.55.0