Re: [PATCH v3 01/10] dt-bindings: phy: qcom,sc8280xp-qmp-usb43dp-phy: Add Glymur compatible
From: Dmitry Baryshkov <hidden>
Date: 2025-09-25 02:50:17
Also in:
linux-arm-msm, linux-devicetree, linux-phy, lkml
On Wed, Sep 24, 2025 at 07:28:41PM -0700, Wesley Cheng wrote:
Define a Glymur compatible string for the QMP PHY combo driver, along with resource requirements. Add a different identifier for the primary QMP PHY instance as it does not require a clkref entry.
This is no longer true
quoted hunk ↗ jump to hunk
Signed-off-by: Wesley Cheng <redacted> --- .../phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-)diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml index c8bc512df08b..2f1f41b64bbd 100644 --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml@@ -16,6 +16,7 @@ description: properties: compatible: enum: + - qcom,glymur-qmp-usb3-dp-phy - qcom,sar2130p-qmp-usb3-dp-phy - qcom,sc7180-qmp-usb3-dp-phy - qcom,sc7280-qmp-usb3-dp-phy@@ -46,7 +47,7 @@ properties: - const: ref - const: com_aux - const: usb3_pipe - - const: cfg_ahb + - enum: [cfg_ahb, clkref]
Either define it using the if/else or split glymur to a new schema file. Such enum allows specifying clkref clock for all the platforms defined by these bindings.
quoted hunk ↗ jump to hunk
power-domains: maxItems: 1@@ -63,6 +64,8 @@ properties: vdda-pll-supply: true + refgen-supply: true + "#clock-cells": const: 1 description:@@ -109,6 +112,7 @@ allOf: properties: compatible: enum: + - qcom,glymur-qmp-usb3-dp-phy - qcom,sc7180-qmp-usb3-dp-phy - qcom,sdm845-qmp-usb3-dp-phy then:@@ -128,6 +132,7 @@ allOf: properties: compatible: enum: + - qcom,glymur-qmp-usb3-dp-phy - qcom,sar2130p-qmp-usb3-dp-phy - qcom,sc8280xp-qmp-usb43dp-phy - qcom,sm6350-qmp-usb3-dp-phy@@ -142,6 +147,18 @@ allOf: properties: power-domains: false + - if: + properties: + compatible: + enum: + - qcom,glymur-qmp-usb3-dp-phy + then: + required: + - refgen-supply + else: + properties: + refgen-supply: false + additionalProperties: false examples:
-- With best wishes Dmitry