Re: [PATCH 5/9] usb: vhci-hcd: Do not split quoted strings
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2025-07-17 16:19:48
Also in:
lkml
On Thu, Jul 17, 2025 at 06:54:54PM +0300, Cristian Ciocaltea wrote:
quoted hunk ↗ jump to hunk
Join the split strings to make checkpatch happy and regain ability to grep for those log messages in the source code: WARNING: quoted string split across lines Signed-off-by: Cristian Ciocaltea <redacted> --- drivers/usb/usbip/vhci_hcd.c | 21 +++++++-------------- 1 file changed, 7 insertions(+), 14 deletions(-)diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c index 3f888455d238b983a6aafa52418fb89a914c32b5..53691d5e77d386b0b0e16fe9d08824baa04c0b1e 100644 --- a/drivers/usb/usbip/vhci_hcd.c +++ b/drivers/usb/usbip/vhci_hcd.c@@ -376,8 +376,7 @@ static int vhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue, switch (wValue) { case USB_PORT_FEAT_SUSPEND: if (hcd->speed >= HCD_USB3) { - pr_err(" ClearPortFeature: USB_PORT_FEAT_SUSPEND req not " - "supported for USB 3.0 roothub\n"); + pr_err(" ClearPortFeature: USB_PORT_FEAT_SUSPEND req not supported for USB 3.0 roothub\n");
Why the leading " "? And shouldn't this be dev_err()?
quoted hunk ↗ jump to hunk
goto error; }@@ -506,8 +505,7 @@ static int vhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue, case USB_PORT_FEAT_LINK_STATE: usbip_dbg_vhci_rh(" SetPortFeature: USB_PORT_FEAT_LINK_STATE\n"); if (hcd->speed < HCD_USB3) { - pr_err("USB_PORT_FEAT_LINK_STATE req not " - "supported for USB 2.0 roothub\n"); + pr_err("USB_PORT_FEAT_LINK_STATE req not supported for USB 2.0 roothub\n");
dev_err()? Same for the others. thanks, greg k-h