Thread (8 messages) 8 messages, 4 authors, 2022-01-02

Re: [PATCH] net: usb: pegasus: Do not drop long Ethernet frames

From: Andrew Lunn <andrew@lunn.ch>
Date: 2021-12-26 16:31:49
Also in: netdev

quoted
I've nothing against this patch, but if you are working on the driver,
it would be nice to replace these hex numbers with #defines using BIT,
or FIELD. It will make the code more readable.
Replacing the constants with macros is on my list of things that I want
to do. In this case, I did not do it because I wanted to a have small
patch that gets easily accepted and allows me to figure out the current
process to submit patches after years of inactivity.
Agreed, keep fixes simple.

A few other hints. If you consider this a fix which should be back
ported, please add a Fixes: tag, where the issue started. This can be
back as far as the first commit for the driver. Fixes should also be
sent to the net tree, not net-next. See the netdev FAQ about the two
different trees.

	  Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help