Hi Thorsten,

Tue, Dec 21, 2021 at 03:39:04PM +0100, Thorsten Leemhuis kirjoitti:

On 21.12.21 15:03, Heikki Krogerus wrote:

quoted

The driver must make sure there is an actual connection
before checking details about the USB Power Delivery
contract. Those details are not valid unless there is a
connection.

This fixes NULL pointer dereference that is caused by an
attempt to register bogus partner alternate mode that the
firmware on some platform may report before the actual
connection.

Reported-by: Chris Hixon <redacted>
Fixes: 6cbe4b2d5a3f ("usb: typec: ucsi: Check the partner alt modes always if there is PD contract")
Link: https://bugzilla.kernel.org/show_bug.cgi?id=215117
Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
---

Hi,

Instead of using the "BugLink" tag, I'm now using "Link" tag with the
link to the bug as requested.

Thx!

quoted

There was a request to have also another Link tag pointing to some
other discussion on the mailing list, but I failed to understand what
was the point with that - I also didn't find any commits where
something like that had been used before.

There are quite a few commits that use more that two "Link" tags, as
they should point to "related discussions or any other background
information behind the change" that "can be found on the web" (Quotes
from Documentation/process/submitting-patches.rst) -- hence there is no
limit. That being said:

quoted

I may be mistaken here, but I got the impression that you create the
mailing list discussion

You are mistaken: I created it because the bugzilla ticket was ignored
in bugzilla for weeks and might have forgotten otherwise -- no wonder,
was bugzilla.kernel.org is not the official place to report USB bugs
according to the MAINTAINERS file.

quoted

just so you can have the extra Link tag
pointing to it, and that Link tag you want only because you have made
your scripts rely on it.

They rely on it as almost all subsystems expect bug to be reported by
mail, as they are instructed by
Documentation/admin-guide/reporting-issues.rst

quoted

The extra email thread in any case does not seem to contain any real
additional information that the bug report does not have, so the extra
Link tag pointing to it does not provide any real value on top of the
link to bug itself.

In this case that's true, as I have to tell regzbot about the fix then
manually (the plan it to make regzbot also detect links to
bugzilla.kernel.org, but I fear I have no time to work on that in the
next few weeks :-/ ). But in similar cases it's different, as there the
developers continued discussing the issue by mail -- then it's
definitely worth linking there as well.

Thanks for the explanation. My concern was that we are expected to
supply duplicated information just so the bot is satisfied, but
that's clearly not the case. I misunderstood.

thanks,

-- 
heikki