Re: [PATCH v4 1/2] usb: gadget: don't release an existing dev->buf
From: Alan Stern <stern@rowland.harvard.edu>
Date: 2021-12-31 17:34:49
Also in:
lkml
On Sat, Jan 01, 2022 at 01:21:37AM +0800, Hangyu Hua wrote:
dev->buf does not need to be released if it already exists before executing dev_config. Signed-off-by: Hangyu Hua <redacted> ---
Acked-by: Alan Stern <stern@rowland.harvard.edu>
quoted hunk ↗ jump to hunk
drivers/usb/gadget/legacy/inode.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)diff --git a/drivers/usb/gadget/legacy/inode.c b/drivers/usb/gadget/legacy/inode.c index 3b58f4fc0a80..eaad03c0252f 100644 --- a/drivers/usb/gadget/legacy/inode.c +++ b/drivers/usb/gadget/legacy/inode.c@@ -1826,8 +1826,9 @@ dev_config (struct file *fd, const char __user *buf, size_t len, loff_t *ptr) spin_lock_irq (&dev->lock); value = -EINVAL; if (dev->buf) { + spin_unlock_irq(&dev->lock); kfree(kbuf); - goto fail; + return value; } dev->buf = kbuf;-- 2.25.1