On Mon, Dec 20, 2021 at 02:04:49PM -0500, Marc Ferland wrote:

On Mon, Dec 20, 2021 at 6:19 AM Johan Hovold [off-list ref] wrote:

quoted

Add support for the USB interface of the Sierra Wireless XM1210
receiver.

Note that the device only supports NMEA.

quoted

Reported-by: Marc Ferland <redacted>
Link: https://lore.kernel.org/r/20211027200223.72701-1-ferlandm@amotus.ca (local)
Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/gnss/usb.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gnss/usb.c b/drivers/gnss/usb.c
index 5c0251034def..792235a688ea 100644
--- a/drivers/gnss/usb.c
+++ b/drivers/gnss/usb.c

@@ -17,6 +17,7 @@
 #define GNSS_USB_WRITE_TIMEOUT 1000

 static const struct usb_device_id gnss_usb_id_table[] = {
+       { USB_DEVICE(0x1199, 0xb000) },         /* Sierra Wireless XM1210 */
        { }
 };
 MODULE_DEVICE_TABLE(usb, gnss_usb_id_table);
--

2.32.0

Thank you Johan! Much appreciated!

With your patches applied on my platform (featuring the XM1210) , I get:

# lsmod | grep gnss
gnss_usb 16384 0 - Live 0xffffffffc011b000
gnss 16384 3 gnss_usb, Live 0xffffffffc0082000

# dmesg | grep gnss
gnss: GNSS driver registered with major 244
usbcore: registered new interface driver gnss-usb

# ls -l /dev/gnss0
crw-rw----    1 root     root      244,   0 Apr  8 08:39 /dev/gnss0

I also tested with gpsd and everything is working as expected, hence:

Tested-by: Marc Ferland <redacted>

Thanks for testing, Marc!

I've applied this series now after adding your Tested-by tag to both
patches.

Johan