Thread (7 messages) 7 messages, 3 authors, 2021-12-21

Re: [PATCH v2 2/2] dt-bindings: usb: document snps,dis_split_quirk property in dwc3

From: Yaqin Pan <hidden>
Date: 2021-12-21 14:46:38
Also in: linux-devicetree, lkml

quoted
Add snps,dis_split_quirk property for dwc3 controller

Signed-off-by: Yaqin Pan <redacted>
---
 Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 6 ++++++
 1 file changed, 6 insertions(+)
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
./Documentation/devicetree/bindings/usb/snps,dwc3.yaml:229:3: [error] duplication of key "snps,dis-split-quirk" in mapping (key-duplicates)

dtschema/dtc warnings/errors:
make[1]: *** Deleting file 'Documentation/devicetree/bindings/usb/snps,dwc3.example.dts'
Traceback (most recent call last):
 File "/usr/local/bin/dt-extract-example", line 45, in <module>
   binding = yaml.load(open(args.yamlfile, encoding='utf-8').read())
 File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/main.py", line 434, in load
   return constructor.get_single_data()
 File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 121, in get_single_data
   return self.construct_document(node)
 File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 131, in construct_document
   for _dummy in generator:
 File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 674, in construct_yaml_map
   value = self.construct_mapping(node)
 File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 445, in construct_mapping
   return BaseConstructor.construct_mapping(self, node, deep=deep)
 File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 263, in construct_mapping
   if self.check_mapping_key(node, key_node, mapping, key, value):
 File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 294, in check_mapping_key
   raise DuplicateKeyError(*args)
ruamel.yaml.constructor.DuplicateKeyError: while constructing a mapping
 in "<unicode string>", line 32, column 3
found duplicate key "snps,dis-split-quirk" with value "{}" (original value: "{}")
 in "<unicode string>", line 229, column 3
Sorry, i make a mistake, and the snps,dis_split_quirk should be snps,sprs-ctrl-trans-quirk.
And i will renew the patch.
To suppress this check see:
   http://yaml.readthedocs.io/en/latest/api.html#duplicate-keys

make[1]: *** [Documentation/devicetree/bindings/Makefile:25: Documentation/devicetree/bindings/usb/snps,dwc3.example.dts] Error 1
make[1]: *** Waiting for unfinished jobs....
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help