Thread (16 messages) 16 messages, 5 authors, 2022-01-04

Re: [PATCH v1 1/2] HID: usbhid: enable remote wakeup function for usbhid device

From: zhuyinbo <zhuyinbo@loongson.cn>
Date: 2021-12-10 09:50:27
Also in: linux-input, lkml


在 2021/12/8 下午6:03, Oliver Neukum 写道:
On 08.12.21 10:39, Yinbo Zhu wrote:
quoted
The remote wake-up function is a regular function on usb hid device
and I think keeping it enabled by default will make usb application
more convenient. This patch is to enable remote wakeup function for
usb hid device.
Hi,

I am afraid we cannot do this. It will cause regression.
Consider for example the case of laptops with touchscreens
that will trigger a wake up when the laptop is closed.

     Regards

         Oliver
Hi oliver,


system ask that must it must be accped a acpi lid open event then system 
will always into resume state for laptop, otherwise, eventhough that 
system be wakeuped by other event then system will continue into suspend.

and for laptop usb wakeup that as general ask bios to enable usb wakeup 
then if need do more things to enable usb wakeup I think this usb wakeup 
function isn't friendly and inconveient, so enable it by default.
after add this patch, if want to use usb wakeup function it only need 
enable bios configure it think it is appropriate.

BRs,
Yinbo.
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help