RE: [PATCH v2 1/4] usb: aspeed-vhub: add qualifier descriptor

-----Original Message-----
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sent: Tuesday, November 30, 2021 7:43 PM
To: Neal Liu <neal_liu@aspeedtech.com>
Cc: Felipe Balbi <balbi@kernel.org>; Joel Stanley <joel@jms.id.au>; Andrew
Jeffery [off-list ref]; Cai Huoqing [off-list ref]; Tao Ren
[off-list ref]; Julia Lawall [off-list ref]; kernel test
robot [off-list ref]; Sasha Levin [off-list ref];
linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org;
linux-arm-kernel@lists.infradead.org; linux-aspeed@lists.ozlabs.org;
benh@kernel.crashing.org; BMC-SW [off-list ref]
Subject: Re: [PATCH v2 1/4] usb: aspeed-vhub: add qualifier descriptor

On Tue, Nov 30, 2021 at 07:38:44PM +0800, Neal Liu wrote:

quoted

+Ben.
---

Support qualifier descriptor to pass USB30CV compliance test.

Signed-off-by: Neal Liu <neal_liu@aspeedtech.com>
---

The way you wrote this means that everything below the first --- line will be cut
off if it were to be applied.

That is not what you want.

Please fix.

thanks,

greg k-h

Yes, I'll fix it. Thanks

-Neal