Re: [PATCH] dt-bindings: usb: dwc3-xilinx: Convert USB DWC3 bindings
From: Rob Herring <robh@kernel.org>
Date: 2021-11-30 00:15:30
Also in:
linux-arm-kernel, linux-devicetree, lkml
On Fri, Nov 19, 2021 at 10:58:22AM -0600, Rob Herring wrote:
On Fri, 19 Nov 2021 19:16:08 +0530, Manish Narani wrote:quoted
Convert USB DWC3 bindings to DT schema format using json-schema. Signed-off-by: Manish Narani <redacted> --- .../devicetree/bindings/usb/dwc3-xilinx.txt | 56 ---------- .../devicetree/bindings/usb/dwc3-xilinx.yaml | 119 +++++++++++++++++++++ 2 files changed, 119 insertions(+), 56 deletions(-) delete mode 100644 Documentation/devicetree/bindings/usb/dwc3-xilinx.txt create mode 100644 Documentation/devicetree/bindings/usb/dwc3-xilinx.yamlRunning 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/1557119 usb@ff9d0000: 'phy-names', 'phys' do not match any of the regexes: '^usb@[0-9a-f]+$', 'pinctrl-[0-9]+' arch/arm64/boot/dts/xilinx/avnet-ultra96-rev1.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm015-dc1.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm017-dc3.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu102-rev1.0.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu102-rev1.1.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revB.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu104-revA.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu104-revC.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dt.yaml
Looks like the schema is missing some properties.
usb@ff9d0000: usb@fe200000:interrupt-names: 'oneOf' conditional failed, one must be fixed: arch/arm64/boot/dts/xilinx/avnet-ultra96-rev1.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-smk-k26-revA.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zc1232-revA.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zc1254-revA.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zc1275-revA.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm015-dc1.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm016-dc2.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm017-dc3.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm018-dc4.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm019-dc5.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu102-rev1.0.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu102-rev1.1.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revB.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu104-revA.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu104-revC.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dt.yaml usb@ff9e0000: 'phy-names', 'phys' do not match any of the regexes: '^usb@[0-9a-f]+$', 'pinctrl-[0-9]+' arch/arm64/boot/dts/xilinx/avnet-ultra96-rev1.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm017-dc3.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dt.yaml usb@ff9e0000: usb@fe300000:interrupt-names: 'oneOf' conditional failed, one must be fixed: arch/arm64/boot/dts/xilinx/avnet-ultra96-rev1.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-smk-k26-revA.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zc1232-revA.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zc1254-revA.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zc1275-revA.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm015-dc1.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm016-dc2.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm017-dc3.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm018-dc4.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm019-dc5.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu102-rev1.0.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu102-rev1.1.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revB.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu104-revA.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu104-revC.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dt.yaml arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dt.yaml