Thread (2 messages) 2 messages, 2 authors, 2021-10-25

Re: [PATCH] usb:gadget: f_uac1: fixed sync playback

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2021-10-25 07:19:13

On Fri, Oct 22, 2021 at 04:03:39PM +0200, Pavel Hofman wrote:
The u_audio param fb_max was not set to its default value in f_uac1.c.
As a result the maximum value of Playback Pitch ctl was kept at 1000000,
not allowing to set faster playback pitch for UAC1.

The setting required moving the default constant UAC2_DEF_FB_MAX from
u_uac2.h to FBACK_FAST_MAX in u_audio.h as that header is common for
f_uac1.c and f_uac2.c.

Fixes: 6fec018 ("usb: gadget: u_audio.c: Adding Playback Pitch ctl for
                 sync playback")
Nit, in the future the format for this is:

Fixes: 6fec018a7e70 ("usb: gadget: u_audio.c: Adding Playback Pitch ctl for sync playback")

The kernel documentation about submitting patches should describe this.

I'll go hand-edit it, no worries this time.

thanks,

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help