Re: [RFC PATCH 1/3] blk-mq: Add blk_mq_complete_request_direct()
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Date: 2021-10-15 16:15:38
Also in:
linux-block, linux-mmc, linux-scsi
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Date: 2021-10-15 16:15:38
Also in:
linux-block, linux-mmc, linux-scsi
On 2021-10-15 09:03:28 [-0700], Christoph Hellwig wrote:
On Fri, Oct 15, 2021 at 05:14:10PM +0200, Sebastian Andrzej Siewior wrote:quoted
+void blk_mq_complete_request_direct(struct request *rq) +{ + WRITE_ONCE(rq->state, MQ_RQ_COMPLETE); + rq->q->mq_ops->complete(rq); +}As this is called by the driver we known what ->complete this helper would call. So instead of doing this we could just call blk_mq_set_request_complete and the actual completion helper. The comment above it will need some updates of course.
So blk_mq_set_request_complete(); mmc_blk_mq_complete(); for the mmc driver and no fiddling in the blk-mq then. Sebastian