Re: uac2/hid gadget issues on Win10 hosts

Hi Jack,

Dne 04. 09. 21 v 9:40 Jack Pham napsal(a):

Hi Pavel,

On Mon, Aug 23, 2021 at 03:17:11PM +0200, Pavel Hofman wrote:

quoted

There is a problem with max packet size calculation for EP-IN. It has been
discussed here recently
https://www.spinics.net/lists/linux-usb/msg214615.html

The simple change in the post above fixed Win10 enumeration for me and
another tester.

I faced the same error on Win10 and also tried the above patch and it
worked for me as well.  Are you planning to send a formal patch for it?
If so, you can add my

Tested-by: Jack Pham <redacted>

quoted

Also, there is a problem with feedback value calculation which Win10 ignores
and keeps sending the same amount of samples. The fix is to send number of
samples per the actual packet, not per microframe for USB2. I have not
posted the attached patch as the whole patchset will most likely be reverted
for 5.15 https://www.spinics.net/lists/linux-usb/msg216042.html and I wanted
to wait till the situation works out to avoid confusion. In the attached
patch just change the ->c_srate_active to ->c_srate (the patch is on top of
more changes for switching between multiple samplerates).

It doesn't look like any of the feedback EP changes got reverted for
5.14 / 5.15-rc1 so it looks like the dust has settled.  Are you going to
send the below patch formally as well?

Thanks for testing the patch. I did not want to intrude into Jerome's 
plan. However, if Jerome is OK with the attached patch, I can submit it 
formally and continue with submitting more patches for Win10 support.

Thanks,

Pavel.