Thread (23 messages) 23 messages, 6 authors, 2021-09-29

Re: [PATCH v1 1/6] gcc-plugins/structleak: add makefile var for disabling structleak

From: Brendan Higgins <hidden>
Date: 2021-09-29 20:25:22
Also in: linux-hardening, linux-iio, linux-kbuild, linux-kselftest, linux-mmc, lkml

On Fri, Sep 17, 2021 at 8:48 AM Kees Cook [off-list ref] wrote:
On Thu, Sep 16, 2021 at 11:10:59PM -0700, Brendan Higgins wrote:
quoted
KUnit and structleak don't play nice, so add a makefile variable for
enabling structleak when it complains.

Co-developed-by: Kees Cook <redacted>
For a C-d-b, also include a S-o-b:

Signed-off-by: Kees Cook <redacted>

But otherwise, yes, this is good. :)
Yeah, I know that's necessary for the patch to be accepted, but in
this case, I don't think your original version of this (it wasn't
actually a patch) had a S-o-b on it, so I didn't want to say that you
had signed off on something that you didn't.

I have run into this situation before and handled it this way -
letting the co-developer sign off on the list. Is this something I
should avoid in the future?

In any case, I will resubmit this now that I have your S-o-b.

Thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help