Thread (16 messages) 16 messages, 5 authors, 2021-10-05

Re: [PATCH] r8152: stop submitting rx for -EPROTO

From: Jason-ch Chen <hidden>
Date: 2021-09-29 09:52:45
Also in: linux-arm-kernel, linux-mediatek, lkml, netdev

On Wed, 2021-09-29 at 08:14 +0000, Hayes Wang wrote:
Jason-ch Chen [off-list ref]
quoted
Sent: Wednesday, September 29, 2021 1:18 PM
[...]
quoted
When unplugging RTL8152 Fast Ethernet Adapter which is plugged
into an USB HUB, the driver would get -EPROTO for bulk transfer.
There is a high probability to get the soft/hard lockup
information if the driver continues to submit Rx before the HUB
completes the detection of all hub ports and issue the
disconnect event.
I don't think it is a good idea.
For the other situations which return the same error code, you would
stop the rx, too.
However, the rx may re-work after being resubmitted for the other
cases.

Best Regards,
Hayes
Hi Hayes,

Sometimes Rx submits rapidly and the USB kernel driver of opensource
cannot receive any disconnect event due to CPU heavy loading, which
finally causes a system crash.
Do you have any suggestions to modify the r8152 driver to prevent this
situation happened?

Regards,
Jason
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help