[PATCH net v1 1/1] net: usb: asix: ax88772: fix boolconv.cocci warnings

Subsystems: networking drivers, the rest, usb networking drivers

STALE1829d LANDED: 5 (5M)

1 review trailer; landed in mainline as ec92e524ee91 on 2021-08-25.

2 messages, 2 authors, 2021-08-26 · open the first message on its own page

[PATCH net v1 1/1] net: usb: asix: ax88772: fix boolconv.cocci warnings

From: Oleksij Rempel <o.rempel@pengutronix.de>
Date: 2021-08-25 18:35:58

From: kernel test robot <redacted>

drivers/net/usb/asix_devices.c:757:60-65: WARNING: conversion to bool not needed here

 Remove unneeded conversion to bool

Semantic patch information:
 Relational and logical operators evaluate to bool,
 explicit conversion is overly verbose and unneeded.

Generated by: scripts/coccinelle/misc/boolconv.cocci

Fixes: 7a141e64cf14 ("net: usb: asix: ax88772: move embedded PHY detection as early as possible")
Reported-by: kernel test robot <redacted>
Signed-off-by: kernel test robot <redacted>
Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 drivers/net/usb/asix_devices.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/usb/asix_devices.c b/drivers/net/usb/asix_devices.c
index f6f3955a3a0f..dc87e8caf954 100644
--- a/drivers/net/usb/asix_devices.c
+++ b/drivers/net/usb/asix_devices.c
@@ -754,7 +754,7 @@ static int ax88772_bind(struct usbnet *dev, struct usb_interface *intf)
 		return ret;
 
 	priv->phy_addr = ret;
-	priv->embd_phy = ((priv->phy_addr & 0x1f) == 0x10 ? true : false);
+	priv->embd_phy = ((priv->phy_addr & 0x1f) == 0x10);
 
 	asix_read_cmd(dev, AX_CMD_STATMNGSTS_REG, 0, 0, 1, &chipcode, 0);
 	chipcode &= AX_CHIPCODE_MASK;
-- 
2.30.2

Re: [PATCH net v1 1/1] net: usb: asix: ax88772: fix boolconv.cocci warnings

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-08-26 00:50:09

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Wed, 25 Aug 2021 20:35:38 +0200 you wrote:
From: kernel test robot <redacted>

drivers/net/usb/asix_devices.c:757:60-65: WARNING: conversion to bool not needed here

 Remove unneeded conversion to bool

Semantic patch information:
 Relational and logical operators evaluate to bool,
 explicit conversion is overly verbose and unneeded.

[...]
Here is the summary with links:
  - [net,v1,1/1] net: usb: asix: ax88772: fix boolconv.cocci warnings
    https://git.kernel.org/netdev/net/c/ec92e524ee91

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help