Re: [RFC PATCH 2/5] usb: core: hcd: Let usb_add_hcd() indicate if roothub has to be registered
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2021-08-24 13:08:59
Also in:
lkml
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2021-08-24 13:08:59
Also in:
lkml
On Tue, Aug 24, 2021 at 04:22:59PM +0530, Kishon Vijay Abraham I wrote:
No functional change. Add __usb_add_hcd() which takes "register_hub" flag that indicates if roothub has to be registered or not. This is in
"flags" like this are horrid, never do that, except at a local static function level that might make code easier. For this, make a usb_hcd_add_and_register() function, so that you know instantly when seeing it be called, as to what it does. Otherwise you have to go look up a random boolean value and that's impossible to remember over time. thanks, greg k-h