Re: [syzbot] WARNING in hid_submit_ctrl/usb_submit_urb
From: Alan Stern <stern@rowland.harvard.edu>
Date: 2021-08-19 15:26:29
Also in:
linux-input, lkml
On Wed, Aug 18, 2021 at 01:13:06PM -0700, syzbot wrote:
Hello, syzbot has tested the proposed patch but the reproducer is still triggering an issue: WARNING in hid_submit_ctrl/usb_submit_urb ------------[ cut here ]------------ usb 1-1: BOGUS control dir, pipe 80000280 doesn't match bRequestType a1 WARNING: CPU: 1 PID: 10180 at drivers/usb/core/urb.c:410 usb_submit_urb+0x149d/0x18a0 drivers/usb/core/urb.c:410
Looks like I was wrong. Let's see what's really happening. Alan Stern #syz test: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 794c7931a242
--- usb-devel.orig/drivers/hid/usbhid/hid-core.c
+++ usb-devel/drivers/hid/usbhid/hid-core.c@@ -397,6 +397,8 @@ static int hid_submit_ctrl(struct hid_de } else padlen = 0; usbhid->urbctrl->transfer_buffer_length = padlen; + hid_err(hid, "submit_ctrl: maxpacket %d len %d padlen %d\n", + maxpacket, len, padlen); } usbhid->urbctrl->dev = hid_to_usb_dev(hid);