Thread (4 messages) flat view 4 messages, 2 authors, 2021-08-18

Re: [PATCH] usb: gadget: mv_u3d: Change functon call in mv_u3d_probe()

From: Felipe Balbi <balbi@kernel.org>
Date: 2021-08-18 13:13:51
Also in: lkml

Hi,

(first of all, your subject could be a little more descriptive,
something like:

	usb: gadget: mv_u3d: request_irq() after initializing UDC

as that would better detail what you're doing)

Nadezda Lutovinova [off-list ref] writes:
If IRQ occurs between calling  request_irq() and  mv_u3d_eps_init(),
then null pointer dereference occurs since u3d->eps[] wasn't
initialized yet but used in mv_u3d_nuke().

The patch puts registration of the interrupt handler after
initializing of neccesery data.

Found by Linux Driver Verification project (linuxtesting.org).
this looks like an important bug fix, it probably deserves a stable tag
here. Which commit introduce this problem? Otherr than that, commits
looks good.

-- 
balbi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help