Re: [PATCH] usb: Add support for u-blox LARA-R6 modules family
From: Johan Hovold <johan@kernel.org>
Date: 2021-07-01 07:14:31
On Wed, Jun 30, 2021 at 07:09:20PM +0000, Marco De Marco wrote:
Support for u-blox LARA-R6 modules family, usb serial interface.
Please include the interface layout here too (cf. commit 4205cb01f6e9
("USB: serial: option: adding support for ublox R410M")) and post the
output of usb-devices (or lsusb -v) for this device.
Isn't there an ADB interface that should be reserved as well for
example?
Please also use the common "USB: serial: option:" prefix in your commit
summary (Subject).
quoted hunk ↗ jump to hunk
Signed-off-by: Marco De Marco <redacted> ---diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index aeaa3756f..05d0379c9 100644 --- a/drivers/usb/serial/option.c +++ b/drivers/usb/serial/option.c@@ -238,6 +238,7 @@ static void option_instat_callback(struct urb *urb); #define QUECTEL_PRODUCT_UC15 0x9090 /* These u-blox products use Qualcomm's vendor ID */ #define UBLOX_PRODUCT_R410M 0x90b2 +#define UBLOX_PRODUCT_R6XX 0x90fa
Looks like the indentation for the value is off here, or in any case you should be using tabs rather than spaces.
quoted hunk ↗ jump to hunk
/* These Yuga products use Qualcomm's vendor ID */ #define YUGA_PRODUCT_CLM920_NC5 0x9625@@ -1101,6 +1102,8 @@ static const struct usb_device_id option_ids[] = { /* u-blox products using Qualcomm vendor ID */ { USB_DEVICE(QUALCOMM_VENDOR_ID, UBLOX_PRODUCT_R410M), .driver_info = RSVD(1) | RSVD(3) }, + { USB_DEVICE(QUALCOMM_VENDOR_ID, UBLOX_PRODUCT_R6XX), + .driver_info = RSVD(3) }, /* Quectel products using Quectel vendor ID */ { USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EC21, 0xff, 0xff, 0xff), .driver_info = NUMEP2 },
Johan