Thread (7 messages) flat view 7 messages, 4 authors, 2021-09-07

Re: [PATCH] drivers/usb/dwc3: Set PHY ready after soft reset done

From: Felipe Balbi <balbi@kernel.org>
Date: 2021-06-11 13:02:46

Yuan Fang [off-list ref] writes:
It's more safe to set PHY ready after soft reset done

Let's consider a test case like this:
I have a usb PHY which don't need SW initial before access
it, But i have a wrong PHY clock default setting in PHY
register which means PHY is not ready in fact.
in dwc3_core_init, dwc3_core_get_phy will return 0 despite
usb get PHYs with return -ENODEV, and set phys_ready=true
your PHY driver shouldn't return -ENODEV here. Why are you returning
-ENODEV? The PHY isn't ready but it _does_ exist.

-- 
balbi

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help