Re: [PATCH] usb: cdns3: Fixed incorrect gadget state
From: Peter Chen <peter.chen@kernel.org>
Date: 2021-06-26 08:57:06
Also in:
lkml, stable
On 21-06-23 09:02:47, Pawel Laszczak wrote:
From: Pawel Laszczak <pawell@cadence.com> For delayed status phase, the usb_gadget->state was set to USB_STATE_ADDRESS and it has never been updated to USB_STATE_CONFIGURED. Patch updates the gadget state to correct USB_STATE_CONFIGURED. As a result of this bug the controller was not able to enter to Test Mode while using MSC function.
Pawel, would you please describe more about this issue? I remember the cdns3 controller at i.mx series SoC could enter test mode by using current code. Peter
quoted hunk ↗ jump to hunk
Cc: <redacted> Fixes: 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver") Signed-off-by: Pawel Laszczak <pawell@cadence.com> --- drivers/usb/cdns3/cdns3-ep0.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/usb/cdns3/cdns3-ep0.c b/drivers/usb/cdns3/cdns3-ep0.c index 9a17802275d5..ec5bfd8944c3 100644 --- a/drivers/usb/cdns3/cdns3-ep0.c +++ b/drivers/usb/cdns3/cdns3-ep0.c@@ -731,6 +731,7 @@ static int cdns3_gadget_ep0_queue(struct usb_ep *ep, request->actual = 0; priv_dev->status_completion_no_call = true; priv_dev->pending_status_request = request; + usb_gadget_set_state(&priv_dev->gadget, USB_STATE_CONFIGURED); spin_unlock_irqrestore(&priv_dev->lock, flags); /*-- 2.25.1
-- Thanks, Peter Chen