Thread (2 messages) flat view 2 messages, 2 authors, 2021-06-24

Re: [PATCH kunit-next] thunderbolt: test: Reinstate a few casts of bitfields

From: Shuah Khan <skhan@linuxfoundation.org>
Date: 2021-06-24 13:13:02
Also in: linux-kselftest, lkml

On 6/24/21 2:48 AM, David Gow wrote:
Partially revert "thunderbolt: test: Remove some casts which are no
longer required". It turns out that typeof() doesn't support bitfields,
so these still need to be cast to the appropriate enum.

The only mention of typeof() and bitfields I can find is in the proposal
to standardise them:
http://www.open-std.org/jtc1/sc22/wg14/www/docs/n2619.htm

This was caught by the kernel test robot:
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org/thread/FDKBHAV7QNLNFU5NBI2RKV56DWDSOLGM/

Fixes: 	8f0877c26e ("thunderbolt: test: Remove some casts which are no longer required")
Reported-by: kernel test robot <redacted>
Signed-off-by: David Gow <redacted>
---

Whoops: I didn't notice this was broken earlier. If it's easier to just
revert the broken patch, that's fine, too.
Thanks for fixing this quickly. I will apply this on top of the broken 
patch.

thanks,
-- Shuah
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help