Thread (1 message) 1 message, 1 author, 2021-06-14
STALE1885d REVIEWED: 1 (0M)

1 review trailer.

[PATCH 5.4 46/84] USB: f_ncm: ncm_bitrate (speed) is unsigned

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2021-06-14 10:58:45
Also in: lkml, stable

From: Maciej Żenczykowski <redacted>

commit 3370139745853f7826895293e8ac3aec1430508e upstream.

[  190.544755] configfs-gadget gadget: notify speed -44967296

This is because 4250000000 - 2**32 is -44967296.

Fixes: 9f6ce4240a2b ("usb: gadget: f_ncm.c added")
Cc: Brooke Basile <redacted>
Cc: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: Felipe Balbi <balbi@kernel.org>
Cc: Lorenzo Colitti <redacted>
Cc: Yauheni Kaliuta <redacted>
Cc: Linux USB Mailing List <redacted>
Acked-By: Lorenzo Colitti <redacted>
Signed-off-by: Maciej Żenczykowski <redacted>
Cc: stable <redacted>
Link: https://lore.kernel.org/r/20210608005344.3762668-1-zenczykowski@gmail.com (local)
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/usb/gadget/function/f_ncm.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/usb/gadget/function/f_ncm.c
+++ b/drivers/usb/gadget/function/f_ncm.c
@@ -583,7 +583,7 @@ static void ncm_do_notify(struct f_ncm *
 		data[0] = cpu_to_le32(ncm_bitrate(cdev->gadget));
 		data[1] = data[0];
 
-		DBG(cdev, "notify speed %d\n", ncm_bitrate(cdev->gadget));
+		DBG(cdev, "notify speed %u\n", ncm_bitrate(cdev->gadget));
 		ncm->notify_state = NCM_NOTIFY_CONNECT;
 		break;
 	}

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help