Re: [PATCH v2 4/4] dt-bindings: pci: qcom: Document PCIe bindings for SC720
From: Bjorn Andersson <hidden>
Date: 2021-06-06 02:20:12
Also in:
linux-arm-msm, linux-devicetree, lkml
On Sat 05 Jun 09:40 CDT 2021, Prasad Malisetty wrote:
quoted hunk ↗ jump to hunk
Document the PCIe DT bindings for SC7280 SoC.The PCIe IP is similar to the one used on SM8250. Add the compatible for SC7280. Signed-off-by: Prasad Malisetty <redacted> Acked-by: Rob Herring <robh@kernel.org> --- Documentation/devicetree/bindings/pci/qcom,pcie.txt | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.txt b/Documentation/devicetree/bindings/pci/qcom,pcie.txt index 25f4def..9c0908f 100644 --- a/Documentation/devicetree/bindings/pci/qcom,pcie.txt +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.txt@@ -12,6 +12,7 @@ - "qcom,pcie-ipq4019" for ipq4019 - "qcom,pcie-ipq8074" for ipq8074 - "qcom,pcie-qcs404" for qcs404 + - "qcom,pcie-sc7280" for sc7280 - "qcom,pcie-sdm845" for sdm845 - "qcom,pcie-sm8250" for sm8250 - "qcom,pcie-ipq6018" for ipq6018@@ -144,6 +145,22 @@ - "slave_bus" AXI Slave clock - clock-names: + Usage: required for sc7280 + Value type: <stringlist> + Definition: Should contain the following entries + - "aux" Auxiliary clock + - "cfg" Configuration clock + - "bus_master" Master AXI clock + - "bus_slave" Slave AXI clock + - "slave_q2a" Slave Q2A clock + - "tbu" PCIe TBU clock + - "ddrss_sf_tbu" PCIe SF TBU clock + - "pipe" PIPE clock + - "pipe_src" PIPE MUX
If you describe it as pipe _mux_, then name it pipe_mux.
+ - "pipe_ext" PIPE output clock
Better to name this in a way that indicates that it is the pipe clock coming out of the phy, perhaps "phy_pipe". But that said, as Stephen points out ensuring that the pipe_clk_src's parent is the phy's clock can be done in DT directly. Regards, Bjorn
+ - "ref" REFERENCE clock + +- clock-names: Usage: required for sdm845 Value type: <stringlist> Definition: Should contain the following entries -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project