Thread (1 message) 1 message, 1 author, 2021-06-03
STALE1899d REVIEWED: 1 (0M)

1 review trailer.

[PATCH AUTOSEL 5.4 04/31] usb: cdns3: Fix runtime PM imbalance on error

From: Sasha Levin <sashal@kernel.org>
Date: 2021-06-03 17:12:38
Also in: lkml, stable
Subsystem: cadence usb3 drd ip driver, cadence usbssp drd ip driver, the rest, usb subsystem · Maintainers: Peter Chen, Pawel Laszczak, Linus Torvalds, Greg Kroah-Hartman

From: Dinghao Liu <redacted>

[ Upstream commit e5b913496099527abe46e175e5e2c844367bded0 ]

pm_runtime_get_sync() increments the runtime PM usage counter even
when it returns an error code. Thus a pairing decrement is needed on
the error handling path to keep the counter balanced.

Reviewed-by: Peter Chen <redacted>
Signed-off-by: Dinghao Liu <redacted>
Signed-off-by: Felipe Balbi <balbi@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/usb/cdns3/gadget.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/cdns3/gadget.c b/drivers/usb/cdns3/gadget.c
index c0c39cf30387..f32f00c49571 100644
--- a/drivers/usb/cdns3/gadget.c
+++ b/drivers/usb/cdns3/gadget.c
@@ -2706,8 +2706,10 @@ static int __cdns3_gadget_init(struct cdns3 *cdns)
 	pm_runtime_get_sync(cdns->dev);
 
 	ret = cdns3_gadget_start(cdns);
-	if (ret)
+	if (ret) {
+		pm_runtime_put_sync(cdns->dev);
 		return ret;
+	}
 
 	/*
 	 * Because interrupt line can be shared with other components in
-- 
2.30.2
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help