[PATCH AUTOSEL 5.10 07/39] usb: cdns3: Fix runtime PM imbalance on error
From: Sasha Levin <sashal@kernel.org>
Date: 2021-06-03 17:10:11
Also in:
lkml, stable
Subsystem:
cadence usb3 drd ip driver, cadence usbssp drd ip driver, the rest, usb subsystem · Maintainers:
Peter Chen, Pawel Laszczak, Linus Torvalds, Greg Kroah-Hartman
From: Dinghao Liu <redacted> [ Upstream commit 07adc0225484fc199e3dc15ec889f75f498c4fca ] When cdns3_gadget_start() fails, a pairing PM usage counter decrement is needed to keep the counter balanced. Signed-off-by: Dinghao Liu <redacted> Link: https://lore.kernel.org/r/20210412054908.7975-1-dinghao.liu@zju.edu.cn (local) Signed-off-by: Peter Chen <peter.chen@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org> --- drivers/usb/cdns3/gadget.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/cdns3/gadget.c b/drivers/usb/cdns3/gadget.c
index 0aa85cc07ff1..c24c0e3440e3 100644
--- a/drivers/usb/cdns3/gadget.c
+++ b/drivers/usb/cdns3/gadget.c@@ -3255,8 +3255,10 @@ static int __cdns3_gadget_init(struct cdns3 *cdns) pm_runtime_get_sync(cdns->dev); ret = cdns3_gadget_start(cdns); - if (ret) + if (ret) { + pm_runtime_put_sync(cdns->dev); return ret; + } /* * Because interrupt line can be shared with other components in
--
2.30.2