Re: [PATCH -next] usb: typec: tcpci: Make symbol 'tcpci_apply_rc' static
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Date: 2021-05-26 06:26:43
Also in:
kernel-janitors
On Mon, May 24, 2021 at 01:37:04PM +0000, Wei Yongjun wrote:
The sparse tool complains as follows:
drivers/usb/typec/tcpm/tcpci.c:118:5: warning:
symbol 'tcpci_apply_rc' was not declared. Should it be static?
This symbol is not used outside of tcpci.c, so marks it static.
Fixes: 7257fbc7c598 ("usb: typec: tcpci: Implement callback for apply_rc")
Reported-by: Hulk Robot <redacted>
Signed-off-by: Wei Yongjun <redacted>Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
quoted hunk ↗ jump to hunk
--- drivers/usb/typec/tcpm/tcpci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)diff --git a/drivers/usb/typec/tcpm/tcpci.c b/drivers/usb/typec/tcpm/tcpci.c index 34b5095cc84f..22862345d1ab 100644 --- a/drivers/usb/typec/tcpm/tcpci.c +++ b/drivers/usb/typec/tcpm/tcpci.c@@ -115,7 +115,8 @@ static int tcpci_set_cc(struct tcpc_dev *tcpc, enum typec_cc_status cc) return 0; } -int tcpci_apply_rc(struct tcpc_dev *tcpc, enum typec_cc_status cc, enum typec_cc_polarity polarity) +static int tcpci_apply_rc(struct tcpc_dev *tcpc, enum typec_cc_status cc, + enum typec_cc_polarity polarity) { struct tcpci *tcpci = tcpc_to_tcpci(tcpc); unsigned int reg;
-- heikki